Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing ObservedTimestamp. #1985

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

owent
Copy link
Member

@owent owent commented Feb 15, 2023

Fixes #1984

Changes

Please provide a brief description of the changes here.

  • Fix missing ObservedTimestamp.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team February 15, 2023 02:52
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1985 (469eb1c) into main (4daca39) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         166      166           
  Lines        4597     4597           
=======================================
  Hits         4005     4005           
  Misses        592      592           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@ThomsonTan ThomsonTan merged commit e47dec5 into open-telemetry:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservedTimestamp should be set when using logs SDK
4 participants